From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Paul Mackerras <paulus@ozlabs.org>, Thomas Huth <thuth@redhat.com>
Cc: linuxppc-dev@lists.ozlabs.org, Alexander Graf <agraf@suse.com>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: ppc: Fix size of the PSPB register
Date: Tue, 01 Sep 2015 22:30:25 +0000 [thread overview]
Message-ID: <1441146625.2668.53.camel@au1.ibm.com> (raw)
In-Reply-To: <20150901222434.GA23007@fergus.ozlabs.ibm.com>
On Wed, 2015-09-02 at 08:24 +1000, Paul Mackerras wrote:
> On Tue, Sep 01, 2015 at 11:41:18PM +0200, Thomas Huth wrote:
> > The size of the Problem State Priority Boost Register is only
> > 32 bits, so let's change the type of the corresponding variable
> > accordingly to avoid future trouble.
>
> Since we're already using lwz/stw in the assembly code in
> book3s_hv_rmhandlers.S, this is actually a bug fix, isn't it?
> How did you find it? Did you observe a failure of some kind, or did
> you just find it by code inspection?
Won't the fix break migration ? Unless qemu doens't migrate it ...
> Paul.
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2015-09-01 22:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 21:41 [PATCH] KVM: ppc: Fix size of the PSPB register Thomas Huth
2015-09-01 22:24 ` Paul Mackerras
2015-09-01 22:30 ` Benjamin Herrenschmidt [this message]
2015-09-02 7:16 ` Thomas Huth
2015-09-01 22:25 ` Benjamin Herrenschmidt
2015-09-01 22:45 ` Paul Mackerras
2015-09-01 22:55 ` Benjamin Herrenschmidt
2015-09-02 7:26 ` Thomas Huth
2015-09-02 8:26 ` Alexander Graf
2015-09-02 8:35 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441146625.2668.53.camel@au1.ibm.com \
--to=benh@au1.ibm.com \
--cc=agraf@suse.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@ozlabs.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox