From: Scott Wood <scottwood@freescale.com>
To: kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] powerpc/e500: move qemu machine spec together with the rest
Date: Wed, 09 Sep 2015 23:01:37 +0000 [thread overview]
Message-ID: <1441839697.2623.21.camel@freescale.com> (raw)
In-Reply-To: <55E992AE.3010605@freescale.com>
On Fri, 2015-09-04 at 15:46 +0300, Laurentiu Tudor wrote:
> This way we get rid of an entire file with mostly
> duplicated code plus a Kconfig option that you always
> had to take care to check it in order for kvm to work.
>
> Signed-off-by: Laurentiu Tudor <Laurentiu.Tudor@freescale.com>
> ---
> arch/powerpc/platforms/85xx/Kconfig | 15 -----
> arch/powerpc/platforms/85xx/Makefile | 1 -
> arch/powerpc/platforms/85xx/corenet_generic.c | 1 +
> arch/powerpc/platforms/85xx/qemu_e500.c | 85 ------------------------
qemu_e500 is not only for corenet chips. We can add it to the defconfig (in
fact I've been meaning to do so).
> -static void __init qemu_e500_setup_arch(void)
> -{
> - ppc_md.progress("qemu_e500_setup_arch()", 0);
> -
> - fsl_pci_assign_primary();
> - swiotlb_detect_4g();
Where is fsl_pci_assign_primary() in corenet_generic.c? At one point this
was needed for QEMU's PCI implementation -- have you tested QEMU PCI without
it?
-Scott
next prev parent reply other threads:[~2015-09-09 23:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 12:46 [PATCH] powerpc/e500: move qemu machine spec together with the rest Laurentiu Tudor
2015-09-09 23:01 ` Scott Wood [this message]
2015-09-14 13:17 ` Laurentiu Tudor
2015-09-14 14:14 ` Alexander Graf
2015-09-14 15:09 ` Scott Wood
2015-09-14 15:11 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441839697.2623.21.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=kvm-ppc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox