From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Wed, 06 Mar 2013 11:57:21 +0000 Subject: Re: in-kernel interrupt controller steering Message-Id: <1772234735.3176599.1362571041893.JavaMail.root@redhat.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Stuart Yoder , Scott Wood , Paul Mackerras , Peter Maydell , Gleb Natapov > > I agree. But is the device really being created at CREATE_DEVICE > > time? What happens if you create N CPUs and N-1 irqchips? > > irqchip in CREATE_DEVICE is the IOAPIC, not the LAPIC. The LAPIC gets > spawned at vcpu creation. > > > On x86, the LAPIC is created magically together with the VCPU. > > Yes, and so far I haven't seen any proposal to change this even in > the CREATE_DEVICE world. But don't you need anyway an id to get/set the device properties of the per-VCPU irqchip? If you were adding the x86 irqchip with the new API, what would be the replacement of KVM_GET_LAPIC/KVM_SET_LAPIC? Paolo