From: Tony Breeds <tony@bakeyournoodle.com>
To: ehrhardt@linux.vnet.ibm.com
Cc: linuxppc-dev@ozlabs.org, embedded-hypervisor@power.org,
hollisb@us.ibm.com, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 2/6] kvmppc: add hypercall infrastructure - host part
Date: Thu, 24 Jul 2008 01:43:53 +0000 [thread overview]
Message-ID: <20080724014352.GI20457@bakeyournoodle.com> (raw)
In-Reply-To: <1216802207-32675-3-git-send-email-ehrhardt@linux.vnet.ibm.com>
On Wed, Jul 23, 2008 at 10:36:43AM +0200, ehrhardt@linux.vnet.ibm.com wrote:
> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Hi Christian,
A few comments
> diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
> --- a/arch/powerpc/kvm/emulate.c
> +++ b/arch/powerpc/kvm/emulate.c
> @@ -203,6 +203,24 @@
> kvmppc_set_msr(vcpu, vcpu->arch.srr1);
> }
>
> +static int kvmppc_do_hypercall(struct kvm_vcpu *vcpu)
> +{
> + int ret = 0;
> +
> + switch (vcpu->arch.gpr[0]) {
> + default:
> + printk(KERN_ERR"unknown hypercall %d\n", vcpu->arch.gpr[0]);
I think the preffered style is printk(KERN_ERR "...) You've made the
same style mistake in most of you printk()'s in your other patches
aswell.
Yours Tony
linux.conf.au http://www.marchsouth.org/
Jan 19 - 24 2009 The Australian Linux Technical Conference!
next prev parent reply other threads:[~2008-07-24 1:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 8:36 [PATCH 0/6][RFC] kvmppc: paravirtualization interface ehrhardt
2008-07-23 8:36 ` [PATCH 1/6] kvmppc: read device tree hypervisor node infrastructure ehrhardt
2008-07-24 1:41 ` Tony Breeds
2008-07-24 7:44 ` Christian Ehrhardt
2008-07-23 8:36 ` [PATCH 2/6] kvmppc: add hypercall infrastructure - host part ehrhardt
2008-07-24 1:43 ` Tony Breeds [this message]
2008-07-30 13:41 ` Geert Uytterhoeven
2008-07-23 8:36 ` [PATCH 3/6] kvmppc: add hypercall infrastructure - guest part ehrhardt
2008-07-24 1:45 ` Tony Breeds
2008-07-24 7:56 ` Christian Ehrhardt
2008-07-23 8:36 ` [PATCH 4/6] kvmppc: magic page hypercall - host part ehrhardt
2008-07-24 1:49 ` Tony Breeds
2008-07-23 8:36 ` [PATCH 5/6] kvmppc: magic page paravirtualization - guest part ehrhardt
2008-07-24 1:59 ` Tony Breeds
2008-07-23 8:36 ` [PATCH 6/6] kvmppc: kvm-userspace: device tree modification for magicpage ehrhardt
2008-07-24 2:01 ` [PATCH 0/6][RFC] kvmppc: paravirtualization interface Tony Breeds
2008-07-24 8:17 ` Christian Ehrhardt
2008-07-25 1:08 ` Tony Breeds
2008-08-19 10:36 ` [PATCH 0/6][RFC] kvmppc: paravirtualization interface - host part v2 ehrhardt
2008-09-16 6:27 ` [PATCH 0/6][RFC] kvmppc: paravirtualization interface - host part v3 ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724014352.GI20457@bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=embedded-hypervisor@power.org \
--cc=hollisb@us.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox