From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aurelien Jarno Date: Thu, 19 Feb 2009 22:41:53 +0000 Subject: Re: [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 Message-Id: <20090219224153.GE27283@hall.aurel32.net> List-Id: References: <1234864778-19099-1-git-send-email-yu.liu@freescale.com> <1234864778-19099-2-git-send-email-yu.liu@freescale.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: qemu-devel@nongnu.org Cc: Blue Swirl , Liu Yu , hollisb@us.ibm.com, kvm-ppc@vger.kernel.org On Tue, Feb 17, 2009 at 04:55:51PM +0200, Blue Swirl wrote: > On 2/17/09, Liu Yu wrote: > > MPIC and OpenPIC have very similar design. > > So a lot of code can be reused. > > > > Modification mainly include: > > 1. keep struct openpic_t to the maximum size of both MPIC and OpenPIC. > > 2. endianess swap. > > MPIC has the same endianess as target, so no need to swap for MPIC. > > I don't think this is correct, the host can still be different endian > from target. > I do not agree. As long as we don't manipulate host memory, the host endianess has nothing to do. The values are simply passed by value, they don't need to be swapped. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net