From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Mon, 10 May 2010 12:01:51 +0000 Subject: Re: [RFC][PATCH resend 8/12] asm-generic: bitops: introduce le bit offset macro Message-Id: <201005101401.52182.arnd@arndb.de> List-Id: References: <20100504215645.6448af8f.takuya.yoshikawa@gmail.com> <201005061538.54326.arnd@arndb.de> <4BE7F22E.9070504@oss.ntt.co.jp> In-Reply-To: <4BE7F22E.9070504@oss.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Takuya Yoshikawa Cc: Takuya Yoshikawa , Avi Kivity , mtosatti@redhat.com, agraf@suse.de, fernando@oss.ntt.co.jp, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@ozlabs.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Monday 10 May 2010, Takuya Yoshikawa wrote: > (2010/05/06 22:38), Arnd Bergmann wrote: > > On Wednesday 05 May 2010, Takuya Yoshikawa wrote: > >> There was a suggestion to propose set_le_bit_user() kind of macros. > >> But what I thought was these have a constraint you two explained and seemed to be > >> a little bit specific to some area, like KVM. > >> > >> So I decided to propose just the offset calculation macro. > > > > I'm not sure I understand how this macro is going to be used though. > > If you are just using this in kernel space, that's fine, please go for > > it. > > Yes, I'm just using in kernel space: qemu has its own endian related helpers. > > So if you allow us to place this macro in asm-generic/bitops/* it will help us. No problem at all then. Thanks for the explanation. Acked-by: Arnd Bergmann