From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Fri, 01 Apr 2011 18:46:10 +0000 Subject: Re: [linuxppc-release] [PATCH v4 2/4] powerpc/e500: SPE register Message-Id: <20110401134610.0db11430@schlenkerla.am.freescale.net> List-Id: References: <20110330220003.GA13156@schlenkerla.am.freescale.net> In-Reply-To: <20110330220003.GA13156@schlenkerla.am.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On Thu, 31 Mar 2011 01:21:18 -0500 Kumar Gala wrote: > > On Mar 30, 2011, at 5:00 PM, Scott Wood wrote: > > > This allows reuse for saving/restoring KVM SPE state. > > Can you update commit comment to include a little about how we accomplish that. (something about the macro change is all I'm looking for) > > [otherwise ACK] Is this OK: powerpc/e500: SPE register saving: take arbitrary struct offset Previously, these macros hardcoded THREAD_EVR0 as the base of the save area, relative to the base register passed. This base offset is now passed as a separate macro parameter, allowing reuse with other SPE save areas, such as used by KVM. Also, any comment on http://patchwork.ozlabs.org/patch/88677/? -scott