From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrill Gorcunov Date: Tue, 06 Dec 2011 13:38:36 +0000 Subject: Re: [PATCH 23/28] kvm tools: Endian-sanitise pci.h and PCI device Message-Id: <20111206133836.GH29781@moon> List-Id: References: <4EDD8F16.6060104@ozlabs.org> <20111206102856.GB29781@moon> <20111206114755.GC29781@moon> <1323172704.1428.165.camel@jaguar> <20111206121005.GE29781@moon> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Pekka Enberg Cc: Matt Evans , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Asias He , Sasha Levin , Ingo Molnar On Tue, Dec 06, 2011 at 03:29:00PM +0200, Pekka Enberg wrote: > > > >Hehe, this is because it should be rtaher defined as > > > >union pci_config_address { > >struct { > > #if __BYTE_ORDER = __LITTLE_ENDIAN > > unsigned zeros : 2; > > unsigned register_number : 6; > > #else > > ... > > #endif > >} > >u32 w; > >}; > > Yup, that fixes it for me. > Good. Matt, mind to update? Cyrill