Re: [PATCH 23/28] kvm tools: Endian-sanitise pci.h and PCI device

Matt Evans
2011-12-07T02:58:18Z

On 07/12/11 00:38, Cyrill Gorcunov wrote:
> On Tue, Dec 06, 2011 at 03:29:00PM +0200, Pekka Enberg wrote:
>>>
>>> Hehe, this is because it should be rtaher defined as
>>>
>>> union pci_config_address {
>>> struct {
>>> #if __BYTE_ORDER = __LITTLE_ENDIAN
>>> unsigned zeros : 2;
>>> unsigned register_number : 6;
>>> #else
>>> ...
>>> #endif
>>> }
>>> u32 w;
>>> };
>>
>> Yup, that fixes it for me.
>>
>
> Good. Matt, mind to update?

Absolutely -- thank you for digging in and debugging that! I'll repost a V2.

Cheers,

Matt