Re: [PATCH 24/28] kvm tools: Fix virtio-pci endian bug when reading VIRTIO_PCI_QUEUE_NUM

Pekka Enberg
2011-12-06T11:39:14Z

On Tue, Dec 6, 2011 at 1:28 PM, Asias He <asias.hejun@gmail.com> wrote:
>>> @@ -116,8 +116,7 @@ static bool virtio_pci__io_in(struct ioport *ioport, struct kvm *kvm, u16 port,
>>>                break;
>>>        case VIRTIO_PCI_QUEUE_NUM:
>>>                val = vtrans->virtio_ops->get_size_vq(kvm, vpci->dev, vpci->queue_selector);
>>> -               ioport__write32(data, val);
>>> -               break;
>>> +               ioport__write16(data, val);
>>>                break;
>>>        case VIRTIO_PCI_STATUS:
>>>                ioport__write8(data, vpci->status);
>>
>> Looks good to me. Asias, Sasha?
>
> Looks good to me.

Applied, thanks!