Re: [PATCH 05/28] kvm tools: 64-bit tidy; use PRIx64 when printf'ing

Pekka Enberg
2011-12-07T17:21:04Z

On 12/07/2011 09:16 AM, Ingo Molnar wrote:
>>> > That's what's happening here; we're __powerpc64__ and
>>> > !__KERNEL__, tools/kvm/include/linux/types.h includes
>>> > asm/types.h so gets the int-l64.h definition of __u64, as
>>> > above. :/
>>> >
>>> > builtin-run.c:389: error: format `%llx' expects type `long
>>> > long unsigned int', but argument 2 has type `u64'
>> So either define __KERNEL__ or patch a __NEW_USERSPACE__ define
>> into power/asm/types.h and use it - if the PowerPC folks agree
>> with that approach.
>>
>> Sane userspace should not be prevented from using the same sane
>> types the kernel is already using:-)

On Wed, 7 Dec 2011, Paolo Bonzini wrote:
> I should dig up that patent of mine for "apparatus for conversion of circular
> motion to rectilinear ('wheel')".

What's your point?

We use kernel types for obvious reasons and it trying to use <stdint.h>
for the PPC port is just begging for trouble.

Pekka