Re: [PATCH 08/28] kvm tools: Fix KVM_RUN exit code check

Avi Kivity
2011-12-22T10:03:52Z

On 12/08/2011 07:31 AM, Sasha Levin wrote:
> >
> > It sounds like Alex is considering KVM PPC's return value in this case (and
> > updating api.txt if appropriate) -- what say you on this patch? It actually
> > brings kvmtool's KVM_RUN return val check in line with QEMU's (also "< 0") and
> > nothing PPC will run without it, currently. (I'm about to repost a new series,
> > will include it for these reasons, until I hear more complaint ;) )
>
> '<0' is fine as it's what api.txt says :)

What? ioctls return -1 on error, not <0.

The syscalls do return <0, but libc converts that to -1/errno.

--
error compiling committee.c: too many arguments to function