Re: [PATCH 23/28] kvm tools: Endian-sanitise pci.h and PCI device

Cyrill Gorcunov
2011-12-06T11:47:55Z

On Tue, Dec 06, 2011 at 01:41:56PM +0200, Pekka Enberg wrote:
> On Tue, Dec 6, 2011 at 12:28 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> > On Tue, Dec 06, 2011 at 12:25:29PM +0200, Pekka Enberg wrote:
> >> On Tue, Dec 6, 2011 at 5:42 AM, Matt Evans <matt@ozlabs.org> wrote:
> >> > vesa, pci-shmem and virtio-pci devices need to set up config space with
> >> > little-endian conversions (as config space is LE).  The pci_config_address
> >> > bitfield also needs to be reversed when building on BE systems.
> >> >
> >> > Signed-off-by: Matt Evans <matt@ozlabs.org>
> >>
> >> Looks OK to me. Sasha, Cyrill?
> >>
> >
> > BIOS part looks pretty good to me. LE/BE part as well. Thanks Matt!
>
> Hmm. This seems to break "make check" for me:
>

If you change back to

static struct pci_device_header pci_shmem_pci_device = {
...
.class = 0xFF0000, /* misc pci device */
...
};

does it help?

Cyrill