Re: [PATCH 16/28] kvm tools: Allow load_flat_binary() to load an

Cyrill Gorcunov
2011-12-07T06:33:56Z

On Wed, Dec 07, 2011 at 11:42:27AM +1100, Matt Evans wrote:
> Hi Cyrill,
>
> On 06/12/11 23:04, Cyrill Gorcunov wrote:
> > On Tue, Dec 06, 2011 at 12:29:48PM +0200, Pekka Enberg wrote:
> > ...
> >>
> >> Otherwise looks OK to me. Cyrill?
> >>
> >
> > It might be not seen from patch (or my local kvm repo
> > is not yet updated well) but I somehow miss who will be
> > reading initrd in case of loading flat image? If noone,
> > then what's the point to pass fd there at all?
>
> I pass in the initrd fd in generic code in preparation for the PPC support in
> "[PATCH 1/8] kvm tools: Add initial SPAPR PPC64 architecture support" which uses
> it. As you saw, I haven't made x86 load the initrd in the case of a flat kernel
> binary being loaded; I didn't think a flat kernel can have a non-embedded initrd
> on x86? (My x86 is rusty, this may not be true ;) bootparams are [b]zImage
> only?)
>

Ah, I see. Sorry for confusion. Thanks.

Cyrill