From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Tue, 09 Apr 2013 22:37:13 +0000 Subject: Re: [PATCH 2/7 v3] Rename EMULATE_DO_PAPR to EMULATE_EXIT_USER Message-Id: <20130409223713.GB4456@iris.ozlabs.ibm.com> List-Id: References: <1365417138-8202-1-git-send-email-Bharat.Bhushan@freescale.com> <1365417138-8202-2-git-send-email-Bharat.Bhushan@freescale.com> <1365417138-8202-3-git-send-email-Bharat.Bhushan@freescale.com> In-Reply-To: <1365417138-8202-3-git-send-email-Bharat.Bhushan@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bharat Bhushan Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, agraf@suse.de, scottwood@freescale.com, Bharat Bhushan On Mon, Apr 08, 2013 at 04:02:13PM +0530, Bharat Bhushan wrote: > Instruction emulation return EMULATE_DO_PAPR when it requires > exit to userspace on book3s. Similar return is required > for booke. EMULATE_DO_PAPR reads out to be confusing so it is > renamed to EMULATE_EXIT_USER. This and the following patch look like an unnecessary and confusing change to me. If you want an EMULATE_EXIT_USER, why not just add it and use it in your new code, and leave the EMULATE_DO_PAPR code alone? Paul.