From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Date: Thu, 25 Apr 2013 10:19:10 +0000 Subject: Re: [PATCH 03/17] KVM: Drop __KVM_HAVE_IOAPIC condition on irq routing Message-Id: <20130425101909.GC16463@redhat.com> List-Id: References: <1366380388-25926-1-git-send-email-agraf@suse.de> <1366380388-25926-4-git-send-email-agraf@suse.de> In-Reply-To: <1366380388-25926-4-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: kvm-ppc@vger.kernel.org, "kvm@vger.kernel.org mailing list" , Scott Wood , Marcelo Tosatti , Gleb Natapov On Fri, Apr 19, 2013 at 04:06:14PM +0200, Alexander Graf wrote: > We have a capability enquire system that allows user space to ask kvm > whether a feature is available. > > The point behind this system is that we can have different kernel > configurations with different capabilities and user space can adjust > accordingly. > > Because features can always be non existent, we can drop any #ifdefs > on CAP defines that could be used generically, like the irq routing > bits. These can be easily reused for non-IOAPIC systems as well. > > Signed-off-by: Alexander Graf Acked-by: Michael S. Tsirkin > --- > include/uapi/linux/kvm.h | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 74d0ff3..c741902 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -579,9 +579,7 @@ struct kvm_ppc_smmu_info { > #ifdef __KVM_HAVE_PIT > #define KVM_CAP_REINJECT_CONTROL 24 > #endif > -#ifdef __KVM_HAVE_IOAPIC > #define KVM_CAP_IRQ_ROUTING 25 > -#endif > #define KVM_CAP_IRQ_INJECT_STATUS 26 > #ifdef __KVM_HAVE_DEVICE_ASSIGNMENT > #define KVM_CAP_DEVICE_DEASSIGNMENT 27 > -- > 1.6.0.2 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html