From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Wed, 20 May 2015 22:26:33 +0000 Subject: Re: [PATCH 1/1] KVM: PPC: Book3S: correct width in XER handling Message-Id: <20150520222633.GA23106@iris.ozlabs.ibm.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sam Bobroff Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org On Wed, May 20, 2015 at 03:26:12PM +1000, Sam Bobroff wrote: > In 64 bit kernels, the Fixed Point Exception Register (XER) is a 64 > bit field (e.g. in kvm_regs and kvm_vcpu_arch) and in most places it is > accessed as such. > > This patch corrects places where it is accessed as a 32 bit field by a > 64 bit kernel. In some cases this is via a 32 bit load or store > instruction which, depending on endianness, will cause either the > lower or upper 32 bits to be missed. In another case it is cast as a > u32, causing the upper 32 bits to be cleared. > > This patch corrects those places by extending the access methods to > 64 bits. > > Signed-off-by: Sam Bobroff Acked-by: Paul Mackerras