From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Mon, 21 Dec 2015 01:38:11 +0000 Subject: [RFC] odd code in kvmppc_core_vcpu_free_pr() Message-Id: <20151221013811.GV20997@ZenIV.linux.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org Am I right assuming that free_page((unsigned long)vcpu->arch.shared & PAGE_MASK); has become stale in "KVM: PPC: Book3S: Make magic page properly 4k mappable"? AFAICS, these days ->arch.shared points to the beginning of page, so no masking should be needed... Or am I missing something subtle there?