From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Date: Wed, 18 Oct 2017 08:11:51 +0000 Subject: Re: [RFC kvm-unit-tests PATCH] powerpc: add tests for XICS Message-Id: <20171018081151.yqsql5egdbcdvgyz@kamzik.brq.redhat.com> List-Id: References: <20171012080704.31037-1-lvivier@redhat.com> <5c29e3a9-0ceb-79b3-3bdb-e6e0d20ea4d9@redhat.com> In-Reply-To: <5c29e3a9-0ceb-79b3-3bdb-e6e0d20ea4d9@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Vivier Cc: Thomas Huth , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini On Mon, Oct 16, 2017 at 07:08:03PM +0200, Laurent Vivier wrote: > On 13/10/2017 11:45, Thomas Huth wrote: > > On 12.10.2017 10:07, Laurent Vivier wrote: > >> Check if we can set the xive server and priority, and > >> check we get values that have been set. > >> Check we disable/enable interrupts. > >> > >> This patch also increases NR_CPUS from 8 to 16 > >> (maximum for KVM on POWER9, POWER8 allows 96) > >> > >> Signed-off-by: Laurent Vivier > >> --- > >> Note: I send this as an RFC, because even if this test works well with > >> TCG and POWER8 KVM hosts, it detects some problems with POWER9 KVM hosts > > > > What kind of errors does it detect? Are they expected due to the > > different interrupt controllers? > > > >> main(int argc, char **argv) > >> > >> check_set_time_of_day(); > >> > >> + } else if (strcmp(argv[1], "xics") = 0) { > >> + > > > > Superfluous empty line? > > > >> + check_xics(); > >> + > > This is a standard pattern in kvm-unit-tests: > > ... > } else if (strcmp(argv[1], "XXXX") = 0) { > > function(...); > > } else if (strcmp(argv[1], "YYY") = 0) { > ... > I think that pattern is primarily used in arm/selftest.c and powerpc/selftest.c, which I'm to blame for it. I found it easier to read that way, but do agree it's not a typical use of whitespace. Anyway, to me, it's not a big deal either way. I wouldn't post a patch removing those blank lines, but I also wouldn't request them to be added to patches that don't have them... Thanks, drew