From: Paul Mackerras <paulus@ozlabs.org>
To: kvm-ppc@vger.kernel.org
Subject: Re: [RFC PATCH 19/32] KVM: PPC: Book3S HV: Framework and hcall stubs for nested virtualization
Date: Wed, 26 Sep 2018 11:23:19 +0000 [thread overview]
Message-ID: <20180926112319.GE29799@fergus> (raw)
In-Reply-To: <1537524123-9578-20-git-send-email-paulus@ozlabs.org>
On Wed, Sep 26, 2018 at 03:19:00PM +1000, David Gibson wrote:
> On Fri, Sep 21, 2018 at 08:01:50PM +1000, Paul Mackerras wrote:
> > +static void kvmhv_remove_nested(struct kvm_nested_guest *gp)
> > +{
> > + struct kvm *kvm = gp->parent;
> > + int lpid = gp->l1_lpid;
> > + long ref;
> > +
> > + spin_lock(&kvm->mmu_lock);
> > + if (gp = kvm->arch.nested_guests[lpid]) {
> > + kvm->arch.nested_guests[lpid] = NULL;
> > + while (--lpid >= 0 && !kvm->arch.nested_guests[lpid])
> > + ;
>
> This only looks correct of gp is the guest of KVM with the highest
> l1_lpid. It's not obvious why that would have to be the case.
Not obvious because not true. Good catch. :)
Paul.
next prev parent reply other threads:[~2018-09-26 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 10:01 [RFC PATCH 19/32] KVM: PPC: Book3S HV: Framework and hcall stubs for nested virtualization Paul Mackerras
2018-09-26 5:19 ` David Gibson
2018-09-26 11:16 ` Paul Mackerras
2018-09-26 11:23 ` Paul Mackerras [this message]
2018-09-27 0:47 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926112319.GE29799@fergus \
--to=paulus@ozlabs.org \
--cc=kvm-ppc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox