From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Tue, 19 Feb 2019 03:21:40 +0000 Subject: Re: [RFC PATCH v3 3/4] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls Message-Id: <20190219032140.GA5353@blackberry> List-Id: References: <20190130060726.29958-1-bharata@linux.ibm.com> <20190130060726.29958-4-bharata@linux.ibm.com> In-Reply-To: <20190130060726.29958-4-bharata@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bharata B Rao Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, paulus@au1.ibm.com, benh@linux.ibm.com, aneesh.kumar@linux.vnet.ibm.com, jglisse@redhat.com, linuxram@us.ibm.com, sukadev@linux.vnet.ibm.com On Wed, Jan 30, 2019 at 11:37:25AM +0530, Bharata B Rao wrote: > H_SVM_INIT_START: Initiate securing a VM > H_SVM_INIT_DONE: Conclude securing a VM > > During early guest init, these hcalls will be issued by UV. > As part of these hcalls, [un]register memslots with UV. That last sentence is a bit misleading as it implies that H_SVM_INIT_DONE causes us to unregister the memslots with the UV, which is not the case. Shouldn't it be "As part of H_SVM_INIT_START, register all existing memslots with the UV"? Also, do we subsequently communicate changes in the memslots to the UV? Paul.