From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Fri, 22 Feb 2019 09:41:01 +0000 Subject: Re: [PATCH] KVM: PPC: Book3S HV: Fix build failure without IOMMU support Message-Id: <20190222094101.GE6006@blackberry> List-Id: References: <20190221032848.22590-1-jniethe5@gmail.com> In-Reply-To: <20190221032848.22590-1-jniethe5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jordan Niethe Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org On Thu, Feb 21, 2019 at 02:28:48PM +1100, Jordan Niethe wrote: > Currently trying to build without IOMMU support will fail: > > (.text+0x1380): undefined reference to `kvmppc_h_get_tce' > (.text+0x1384): undefined reference to `kvmppc_rm_h_put_tce' > (.text+0x149c): undefined reference to `kvmppc_rm_h_stuff_tce' > (.text+0x14a0): undefined reference to `kvmppc_rm_h_put_tce_indirect' > > This happens because turning off IOMMU support will prevent > book3s_64_vio_hv.c from being built because it is only built when > SPAPR_TCE_IOMMU is set, which depends on IOMMU support. > > Fix it using ifdefs for the undefined references. > > Fixes: 76d837a4c0f9 ("KVM: PPC: Book3S PR: Don't include SPAPR TCE code on non-pseries platforms") > Signed-off-by: Jordan Niethe Thanks, applied to my kvm-ppc-next tree. Paul.