From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ram Pai Date: Wed, 10 Jul 2019 17:09:32 +0000 Subject: Re: [PATCH v4 5/8] KVM: PPC: Ultravisor: Restrict flush of the partition tlb cache Message-Id: <20190710170932.GA4864@ram.ibm.com> List-Id: References: <20190628200825.31049-1-cclaudio@linux.ibm.com> <20190628200825.31049-6-cclaudio@linux.ibm.com> <134bd0eb97ed6cc616ced38732b9b52c@linux.vnet.ibm.com> In-Reply-To: <134bd0eb97ed6cc616ced38732b9b52c@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: janani Cc: Madhavan Srinivasan , Michael Anderson , Claudio Carvalho , kvm-ppc@vger.kernel.org, Bharata B Rao , linuxppc-dev@ozlabs.org, Ryan Grimm , Sukadev Bhattiprolu , Thiago Bauermann , Anshuman Khandual On Mon, Jul 08, 2019 at 02:54:52PM -0500, janani wrote: > On 2019-06-28 15:08, Claudio Carvalho wrote: > >From: Ram Pai > > > >Ultravisor is responsible for flushing the tlb cache, since it manages > >the PATE entries. Hence skip tlb flush, if the ultravisor firmware is > >available. > > > >Signed-off-by: Ram Pai > >Signed-off-by: Claudio Carvalho > >--- > > arch/powerpc/mm/book3s64/pgtable.c | 33 +++++++++++++++++------------- > > 1 file changed, 19 insertions(+), 14 deletions(-) > > > >diff --git a/arch/powerpc/mm/book3s64/pgtable.c > >b/arch/powerpc/mm/book3s64/pgtable.c > >index 224c5c7c2e3d..bc8eb2bf9810 100644 > >--- a/arch/powerpc/mm/book3s64/pgtable.c > >+++ b/arch/powerpc/mm/book3s64/pgtable.c > >@@ -224,6 +224,23 @@ void __init mmu_partition_table_init(void) > > powernv_set_nmmu_ptcr(ptcr); > > } > > > >+static void flush_partition(unsigned int lpid, unsigned long dw0) > >+{ > >+ if (dw0 & PATB_HR) { > >+ asm volatile(PPC_TLBIE_5(%0, %1, 2, 0, 1) : : > >+ "r" (TLBIEL_INVAL_SET_LPID), "r" (lpid)); > >+ asm volatile(PPC_TLBIE_5(%0, %1, 2, 1, 1) : : > >+ "r" (TLBIEL_INVAL_SET_LPID), "r" (lpid)); > >+ trace_tlbie(lpid, 0, TLBIEL_INVAL_SET_LPID, lpid, 2, 0, 1); > >+ } else { > >+ asm volatile(PPC_TLBIE_5(%0, %1, 2, 0, 0) : : > >+ "r" (TLBIEL_INVAL_SET_LPID), "r" (lpid)); > >+ trace_tlbie(lpid, 0, TLBIEL_INVAL_SET_LPID, lpid, 2, 0, 0); > >+ } > >+ /* do we need fixup here ?*/ > >+ asm volatile("eieio; tlbsync; ptesync" : : : "memory"); > >+} > >+ > > static void __mmu_partition_table_set_entry(unsigned int lpid, > > unsigned long dw0, > > unsigned long dw1) > >@@ -238,20 +255,8 @@ static void > >__mmu_partition_table_set_entry(unsigned int lpid, > > * The type of flush (hash or radix) depends on what the previous > > * use of this partition ID was, not the new use. > > */ > >- asm volatile("ptesync" : : : "memory"); > Doesn't the line above that was deleted need to be added to the > beginning of flush_partition() It has to. It got dropped erroneously. This is a good catch! Thanks, RP