From: Paul Mackerras <paulus@ozlabs.org>
To: Leonardo Bras <leonardo@linux.ibm.com>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH 0/3] Replace current->mm by kvm->mm on powerpc/kvm
Date: Tue, 24 Sep 2019 02:00:08 +0000 [thread overview]
Message-ID: <20190924020008.GA4011@oak.ozlabs.ibm.com> (raw)
In-Reply-To: <20190923212409.7153-1-leonardo@linux.ibm.com>
On Mon, Sep 23, 2019 at 06:24:06PM -0300, Leonardo Bras wrote:
> By replacing, we would reduce the use of 'global' current on code,
> relying more in the contents of kvm struct.
>
> On code, I found that in kvm_create_vm() there is:
> kvm->mm = current->mm;
>
> And that on every kvm_*_ioctl we have tests like that:
> if (kvm->mm != current->mm)
> return -EIO;
>
> So this change would be safe.
>
> I split the changes in 3 patches, so it would be easier to read
> and reject separated parts. If decided that squashing is better,
> I see no problem doing that.
The patch series looks fine. It has missed the 5.4 merge window, and
it doesn't fix any bugs, so I will queue it up for the 5.5 merge
window, meaning that I will put it into my kvm-ppc-next branch when I
prepare it for the 5.5 merge window, probably in about a month from
now.
This remark also applies to your other patch "Reduce calls to get
current->mm by storing the value locally".
Thanks,
Paul.
next prev parent reply other threads:[~2019-09-24 2:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 21:24 [PATCH 0/3] Replace current->mm by kvm->mm on powerpc/kvm Leonardo Bras
2019-09-23 21:24 ` [PATCH 1/3] powerpc/kvm/book3s: Replace current->mm by kvm->mm Leonardo Bras
2019-10-22 5:28 ` Paul Mackerras
2019-09-23 21:24 ` [PATCH 2/3] powerpc/kvm/book3e: " Leonardo Bras
2019-10-22 0:43 ` Paul Mackerras
2019-10-22 14:22 ` Leonardo Bras
2019-09-23 21:24 ` [PATCH 3/3] powerpc/kvm/e500: " Leonardo Bras
2019-09-24 2:00 ` Paul Mackerras [this message]
2019-09-24 13:46 ` [PATCH 0/3] Replace current->mm by kvm->mm on powerpc/kvm Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924020008.GA4011@oak.ozlabs.ibm.com \
--to=paulus@ozlabs.org \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leonardo@linux.ibm.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox