Re: [PATCH v2 12/15] KVM: Provide common implementation for generic dirty log functions

kbuild test robot
2019-10-24T10:28:40Z

[-- Attachment #1: Type: text/plain, Size: 2704 bytes --]

Hi Sean,

I love your patch! Yet something to improve:

[auto build test ERROR on kvm/linux-next]
[cannot apply to v5.4-rc4 next-20191024]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Sean-Christopherson/KVM-Dynamically-size-memslot-arrays/20191024-144336
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: mips-malta_kvm_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=mips

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

arch/mips/kvm/mips.c: In function 'kvm_arch_dirty_log_tlb_flush':
>> arch/mips/kvm/mips.c:976:48: error: 'memslot' undeclared (first use in this function); did you mean 'memset'?
kvm_mips_callbacks->flush_shadow_memslot(kvm, memslot);
^~~~~~~
memset
arch/mips/kvm/mips.c:976:48: note: each undeclared identifier is reported only once for each function it appears in

vim +976 arch/mips/kvm/mips.c

669e846e6c4e13 arch/mips/kvm/kvm_mips.c Sanjay Lal 2012-11-21 972
3e2c881a0e3a6e arch/mips/kvm/mips.c Sean Christopherson 2019-10-21 973 void kvm_arch_dirty_log_tlb_flush(struct kvm *kvm, struct kvm_memory_slot *slot)
2a31b9db153530 arch/mips/kvm/mips.c Paolo Bonzini 2018-10-23 974 {
2a31b9db153530 arch/mips/kvm/mips.c Paolo Bonzini 2018-10-23 975 /* Let implementation handle TLB/GVA invalidation */
2a31b9db153530 arch/mips/kvm/mips.c Paolo Bonzini 2018-10-23 @976 kvm_mips_callbacks->flush_shadow_memslot(kvm, memslot);
2a31b9db153530 arch/mips/kvm/mips.c Paolo Bonzini 2018-10-23 977 }
2a31b9db153530 arch/mips/kvm/mips.c Paolo Bonzini 2018-10-23 978

:::::: The code at line 976 was first introduced by commit
:::::: 2a31b9db153530df4aa02dac8c32837bf5f47019 kvm: introduce manual dirty log reprotect

:::::: TO: Paolo Bonzini <pbonzini@redhat.com>
:::::: CC: Paolo Bonzini <pbonzini@redhat.com>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20625 bytes --]