Re: [PATCH v2 02/15] KVM: Don't free new memslot if allocation of said memslot fails

Christoffer Dall
2019-10-23T09:29:13Z

On Mon, Oct 21, 2019 at 05:35:24PM -0700, Sean Christopherson wrote:
> The two implementations of kvm_arch_create_memslot() in x86 and PPC are
> both good citizens and free up all local resources if creation fails.
> Return immediately (via a superfluous goto) instead of calling
> kvm_free_memslot().
>
> Note, the call to kvm_free_memslot() is effectively an expensive nop in
> this case as there are no resources to be freed.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
> virt/kvm/kvm_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 9afd706dc038..2cb38b2148cb 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1014,7 +1014,7 @@ int __kvm_set_memory_region(struct kvm *kvm,
> new.userspace_addr = mem->userspace_addr;
>
> if (kvm_arch_create_memslot(kvm, &new, npages))
> - goto out_free;
> + goto out;
> }
>
> /* Allocate page dirty bitmap if needed */
> --
> 2.22.0
>

Acked-by: Christoffer Dall <christoffer.dall@arm.com>