Re: [PATCH v2 03/15] KVM: PPC: Move memslot memory allocation into prepare_memory_region()

kbuild test robot
2019-10-24T11:55:20Z

[-- Attachment #1: Type: text/plain, Size: 2648 bytes --]

Hi Sean,

I love your patch! Yet something to improve:

[auto build test ERROR on kvm/linux-next]
[cannot apply to v5.4-rc4 next-20191024]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Sean-Christopherson/KVM-Dynamically-size-memslot-arrays/20191024-144336
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=powerpc

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

arch/powerpc/kvm/powerpc.c: In function 'kvm_arch_prepare_memory_region':
>> arch/powerpc/kvm/powerpc.c:701:9: error: too many arguments to function 'kvmppc_core_prepare_memory_region'
return kvmppc_core_prepare_memory_region(kvm, memslot, mem, change);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/powerpc/kvm/powerpc.c:24:0:
arch/powerpc/include/asm/kvm_ppc.h:206:12: note: declared here
extern int kvmppc_core_prepare_memory_region(struct kvm *kvm,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
>> arch/powerpc/kvm/book3s.c:848:5: error: conflicting types for 'kvmppc_core_prepare_memory_region'
int kvmppc_core_prepare_memory_region(struct kvm *kvm,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/powerpc/kvm/book3s.c:30:0:
arch/powerpc/include/asm/kvm_ppc.h:206:12: note: previous declaration of 'kvmppc_core_prepare_memory_region' was here
extern int kvmppc_core_prepare_memory_region(struct kvm *kvm,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/kvmppc_core_prepare_memory_region +701 arch/powerpc/kvm/powerpc.c

695
696 int kvm_arch_prepare_memory_region(struct kvm *kvm,
697 struct kvm_memory_slot *memslot,
698 const struct kvm_userspace_memory_region *mem,
699 enum kvm_mr_change change)
700 {
> 701 return kvmppc_core_prepare_memory_region(kvm, memslot, mem, change);
702 }
703

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25428 bytes --]