From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bharata B Rao Date: Wed, 06 Nov 2019 08:41:45 +0000 Subject: Re: [PATCH v10 3/8] KVM: PPC: Shared pages support for secure guests Message-Id: <20191106082945.GD21634@in.ibm.com> List-Id: References: <20191104041800.24527-1-bharata@linux.ibm.com> <20191104041800.24527-4-bharata@linux.ibm.com> <20191106045238.GD12069@oak.ozlabs.ibm.com> <20191106082235.GC21634@in.ibm.com> In-Reply-To: <20191106082235.GC21634@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, paulus@au1.ibm.com, aneesh.kumar@linux.vnet.ibm.com, jglisse@redhat.com, cclaudio@linux.ibm.com, linuxram@us.ibm.com, sukadev@linux.vnet.ibm.com, hch@lst.de On Wed, Nov 06, 2019 at 01:52:39PM +0530, Bharata B Rao wrote: > > However, since kvmppc_gfn_is_uvmem_pfn() returned true, doesn't that > > mean that pfn here should be a device pfn, and in fact should be the > > same as uvmem_pfn (possibly with some extra bit(s) set)? > > If secure page is being converted to share, pfn will be uvmem_pfn (device pfn). Also, kvmppc_gfn_is_uvmem_pfn() needn't always return true. It returns true only for secure pages, while this routine handles sharing of both secure and normal pages. Regards, Bharata.