Re: [PATCH v10 4/8] KVM: PPC: Radix changes for secure guest

Paul Mackerras
2019-11-06T05:58:23Z

On Mon, Nov 04, 2019 at 09:47:56AM +0530, Bharata B Rao wrote:
> - After the guest becomes secure, when we handle a page fault of a page
> belonging to SVM in HV, send that page to UV via UV_PAGE_IN.
> - Whenever a page is unmapped on the HV side, inform UV via UV_PAGE_INVAL.
> - Ensure all those routines that walk the secondary page tables of
> the guest don't do so in case of secure VM. For secure guest, the
> active secondary page tables are in secure memory and the secondary
> page tables in HV are freed when guest becomes secure.

Why do we free the page tables? Just to save a little memory? It
feels like it would make things more fragile.

Also, I don't see where the freeing gets done in this patch.

Paul.