From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bharata B Rao Date: Mon, 16 Dec 2019 03:41:11 +0000 Subject: Re: [PATCH V3 2/2] KVM: PPC: Implement H_SVM_INIT_ABORT hcall Message-Id: <20191216032911.GA25495@in.ibm.com> List-Id: References: <20191215021104.GA27378@us.ibm.com> <20191215021208.GB27378@us.ibm.com> In-Reply-To: <20191215021208.GB27378@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sukadev Bhattiprolu Cc: Michael Ellerman , Paul Mackerras , linuxram@us.ibm.com, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org On Sat, Dec 14, 2019 at 06:12:08PM -0800, Sukadev Bhattiprolu wrote: > +unsigned long kvmppc_h_svm_init_abort(struct kvm *kvm) > +{ > + int i; > + > + if (!(kvm->arch.secure_guest & KVMPPC_SECURE_INIT_START)) > + return H_UNSUPPORTED; > + > + for (i = 0; i < KVM_ADDRESS_SPACE_NUM; i++) { > + struct kvm_memory_slot *memslot; > + struct kvm_memslots *slots = __kvm_memslots(kvm, i); > + > + if (!slots) > + continue; > + > + kvm_for_each_memslot(memslot, slots) > + kvmppc_uvmem_drop_pages(memslot, kvm, false); > + } You need to hold srcu_read_lock(&kvm->srcu) here. Regards, Bharata.