From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Date: Tue, 17 Dec 2019 22:48:02 +0000 Subject: Re: [PATCH v4 11/19] KVM: x86: Free arrays for old memslot when moving memslot's base gfn Message-Id: <20191217224802.GA26669@xz-x1> List-Id: References: <20191217204041.10815-1-sean.j.christopherson@intel.com> <20191217204041.10815-12-sean.j.christopherson@intel.com> In-Reply-To: <20191217204041.10815-12-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , Marc Zyngier , linux-arm-kernel@lists.infradead.org, Wanpeng Li , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , kvm@vger.kernel.org, David Hildenbrand , Joerg Roedel , Cornelia Huck , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Jim Mattson On Tue, Dec 17, 2019 at 12:40:33PM -0800, Sean Christopherson wrote: > Explicitly free the metadata arrays (stored in slot->arch) in the old > memslot structure when moving the memslot's base gfn is committed. This > eliminates x86's dependency on kvm_free_memslot() being called when a > memlsot move is committed, and paves the way for removing the funky code > in kvm_free_memslot() that conditionally frees structures based on its > @dont param. > > Signed-off-by: Sean Christopherson Reviewed-by: Peter Xu -- Peter Xu