From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Date: Thu, 19 Dec 2019 19:47:33 +0000 Subject: Re: [PATCH v2 26/45] KVM: s390: Invoke kvm_vcpu_init() before allocating sie_page Message-Id: <20191219204733.791f7380.cohuck@redhat.com> List-Id: References: <20191218215530.2280-1-sean.j.christopherson@intel.com> <20191218215530.2280-27-sean.j.christopherson@intel.com> In-Reply-To: <20191218215530.2280-27-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: Marc Zyngier , James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , James Morse , Julien Thierry , Suzuki K Poulose , David Hildenbrand , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kurz On Wed, 18 Dec 2019 13:55:11 -0800 Sean Christopherson wrote: > Now that s390's implementation of kvm_arch_vcpu_init() is empty, move > the call to kvm_vcpu_init() above the allocation of the sie_page. This > paves the way for moving vcpu allocation and initialization into common > KVM code without any associated functional change. > > Signed-off-by: Sean Christopherson > --- > arch/s390/kvm/kvm-s390.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) Seems to be fine. Reviewed-by: Cornelia Huck