From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Date: Fri, 20 Dec 2019 10:16:24 +0000 Subject: Re: [PATCH v2 44/45] KVM: Move putting of vcpu->pid to kvm_vcpu_destroy() Message-Id: <20191220111624.47e15479.cohuck@redhat.com> List-Id: References: <20191218215530.2280-1-sean.j.christopherson@intel.com> <20191218215530.2280-45-sean.j.christopherson@intel.com> In-Reply-To: <20191218215530.2280-45-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: Marc Zyngier , James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , James Morse , Julien Thierry , Suzuki K Poulose , David Hildenbrand , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kurz On Wed, 18 Dec 2019 13:55:29 -0800 Sean Christopherson wrote: > Move the putting of vcpu->pid to kvm_vcpu_destroy(). vcpu->pid is > guaranteed to be NULL when kvm_vcpu_uninit() is called in the error path > of kvm_vm_ioctl_create_vcpu(), e.g. it is explicitly nullified by > kvm_vcpu_init() and is only changed by KVM_RUN. > > No functional change intended. > > Acked-by: Christoffer Dall > Signed-off-by: Sean Christopherson > --- > virt/kvm/kvm_main.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Cornelia Huck