From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Date: Fri, 20 Dec 2019 10:30:47 +0000 Subject: Re: [PATCH v2 45/45] KVM: Move vcpu->run page allocation out of kvm_vcpu_init() Message-Id: <20191220113047.2865074a.cohuck@redhat.com> List-Id: References: <20191218215530.2280-1-sean.j.christopherson@intel.com> <20191218215530.2280-46-sean.j.christopherson@intel.com> In-Reply-To: <20191218215530.2280-46-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: Marc Zyngier , James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , James Morse , Julien Thierry , Suzuki K Poulose , David Hildenbrand , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kurz On Wed, 18 Dec 2019 13:55:30 -0800 Sean Christopherson wrote: > Open code the allocation and freeing of the vcpu->run page in > kvm_vm_ioctl_create_vcpu() and kvm_vcpu_destroy() respectively. Doing > so allows kvm_vcpu_init() to be a pure init function and eliminates > kvm_vcpu_uninit() entirely. > > Signed-off-by: Sean Christopherson > --- > virt/kvm/kvm_main.c | 34 +++++++++++++--------------------- > 1 file changed, 13 insertions(+), 21 deletions(-) Reviewed-by: Cornelia Huck