From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Date: Wed, 05 Feb 2020 22:28:29 +0000 Subject: Re: [PATCH v5 03/19] KVM: Don't free new memslot if allocation of said memslot fails Message-Id: <20200205222829.GF387680@xz-x1> List-Id: References: <20200121223157.15263-1-sean.j.christopherson@intel.com> <20200121223157.15263-4-sean.j.christopherson@intel.com> In-Reply-To: <20200121223157.15263-4-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= On Tue, Jan 21, 2020 at 02:31:41PM -0800, Sean Christopherson wrote: > The two implementations of kvm_arch_create_memslot() in x86 and PPC are > both good citizens and free up all local resources if creation fails. > Return immediately (via a superfluous goto) instead of calling > kvm_free_memslot(). > > Note, the call to kvm_free_memslot() is effectively an expensive nop in > this case as there are no resources to be freed. (I failed to understand why that is expensive.. but the change looks OK) > > No functional change intended. > > Acked-by: Christoffer Dall > Signed-off-by: Sean Christopherson Reviewed-by: Peter Xu -- Peter Xu