From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Date: Thu, 06 Feb 2020 16:26:39 +0000 Subject: Re: [PATCH v5 10/19] KVM: Drop "const" attribute from old memslot in commit_memory_region() Message-Id: <20200206162639.GC695333@xz-x1> List-Id: References: <20200121223157.15263-1-sean.j.christopherson@intel.com> <20200121223157.15263-11-sean.j.christopherson@intel.com> In-Reply-To: <20200121223157.15263-11-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= On Tue, Jan 21, 2020 at 02:31:48PM -0800, Sean Christopherson wrote: > Drop the "const" attribute from @old in kvm_arch_commit_memory_region() > to allow arch specific code to free arch specific resources in the old > memslot without having to cast away the attribute. Freeing resources in > kvm_arch_commit_memory_region() paves the way for simplifying > kvm_free_memslot() by eliminating the last usage of its @dont param. > > Signed-off-by: Sean Christopherson Reviewed-by: Peter Xu -- Peter Xu