From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Date: Thu, 06 Feb 2020 19:06:41 +0000 Subject: Re: [PATCH v5 14/19] KVM: Clean up local variable usage in __kvm_set_memory_region() Message-Id: <20200206190641.GA700495@xz-x1> List-Id: References: <20200121223157.15263-1-sean.j.christopherson@intel.com> <20200121223157.15263-15-sean.j.christopherson@intel.com> In-Reply-To: <20200121223157.15263-15-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson Cc: Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= On Tue, Jan 21, 2020 at 02:31:52PM -0800, Sean Christopherson wrote: [...] > @@ -1101,52 +1099,55 @@ int __kvm_set_memory_region(struct kvm *kvm, > if (mem->guest_phys_addr + mem->memory_size < mem->guest_phys_addr) > return -EINVAL; > > - slot = id_to_memslot(__kvm_memslots(kvm, as_id), id); > - base_gfn = mem->guest_phys_addr >> PAGE_SHIFT; > - npages = mem->memory_size >> PAGE_SHIFT; > - > - if (npages > KVM_MEM_MAX_NR_PAGES) > - return -EINVAL; > - > /* > * Make a full copy of the old memslot, the pointer will become stale > * when the memslots are re-sorted by update_memslots(). > */ > - old = *slot; > + tmp = id_to_memslot(__kvm_memslots(kvm, as_id), id); > + old = *tmp; > + tmp = NULL; Shall we keep this chunk to the patch where it will be used? Other than that, it looks good to me. Thanks, -- Peter Xu