From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Tue, 18 Feb 2020 17:10:52 +0000 Subject: Re: [PATCH v5 15/19] KVM: Provide common implementation for generic dirty log functions Message-Id: <20200218171052.GE27565@linux.intel.com> List-Id: References: <20200121223157.15263-16-sean.j.christopherson@intel.com> <20200206200200.GC700495@xz-x1> <20200206212120.GF13067@linux.intel.com> <20200206214106.GG700495@xz-x1> <20200207194532.GK2401@linux.intel.com> <20200208001832.GA823968@xz-x1> <20200208004233.GA15581@linux.intel.com> <20200208005334.GB823968@xz-x1> <20200208012938.GC15581@linux.intel.com> <87sgj99q9w.fsf@vitty.brq.redhat.com> In-Reply-To: <87sgj99q9w.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vitaly Kuznetsov Cc: Peter Xu , Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= On Mon, Feb 17, 2020 at 04:39:39PM +0100, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > Unless it's functionally incorrect (Vitaly?), going with option (2) and > > naming the hook kvm_arch_flush_remote_tlbs_memslot() seems like the obvious > > choice, e.g. the final cleanup gives this diff stat: > > (I apologize again for not replying in time) No worries, didn't hinder me in the slightest as I was buried in other stuff last week anyways. > I think this is a valid approach and your option (2) would also be my > choice. I also don't think there's going to be a problem when (if) > Hyper-V adds support for PML (eVMCSv2?). Cool, thanks!