From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Thu, 19 Mar 2020 18:50:15 +0000 Subject: Re: ensure device private pages have an owner v2 Message-Id: <20200319185015.GM20941@ziepe.ca> List-Id: References: <20200316193216.920734-1-hch@lst.de> <20200319002849.GG20941@ziepe.ca> <20200319071633.GA32522@lst.de> In-Reply-To: <20200319071633.GA32522@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Dan Williams , Bharata B Rao , Christian =?utf-8?B?S8O2bmln?= , Ben Skeggs , Jerome Glisse , kvm-ppc@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-mm@kvack.org On Thu, Mar 19, 2020 at 08:16:33AM +0100, Christoph Hellwig wrote: > On Wed, Mar 18, 2020 at 09:28:49PM -0300, Jason Gunthorpe wrote: > > > Changes since v1: > > > - split out the pgmap->owner addition into a separate patch > > > - check pgmap->owner is set for device private mappings > > > - rename the dev_private_owner field in struct migrate_vma to src_owner > > > - refuse to migrate private pages if src_owner is not set > > > - keep the non-fault device private handling in hmm_range_fault > > > > I'm happy enough to take this, did you have plans for a v3? > > I think the only open question is if merging 3 and 4 might make sense. > It's up to you if you want it resent that way or not. Okay, I kept it as is and elaborated the commit messages a bit based on the discussion It doesn't seem like the changes outside hmm are significant enough to need more acks Thanks, Jason