From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Thu, 19 Mar 2020 23:31:19 +0000 Subject: Re: [PATCH] KVM: PPC: Book3S HV: Use RADIX_PTE_INDEX_SIZE in Radix MMU code Message-Id: <20200319233118.GB3260@blackberry> List-Id: References: <20200218043650.24410-1-mpe@ellerman.id.au> In-Reply-To: <20200218043650.24410-1-mpe@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michael Ellerman Cc: linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org On Tue, Feb 18, 2020 at 03:36:50PM +1100, Michael Ellerman wrote: > In kvmppc_unmap_free_pte() in book3s_64_mmu_radix.c, we use the > non-constant value PTE_INDEX_SIZE to clear a PTE page. > > We can instead use the constant RADIX_PTE_INDEX_SIZE, because we know > this code will only be running when the Radix MMU is active. > > Note that we already use RADIX_PTE_INDEX_SIZE for the allocation of > kvm_pte_cache. > > Signed-off-by: Michael Ellerman Thanks, applied to my kvm-ppc-next branch. Paul.