From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Tue, 28 Jul 2020 19:15:18 +0000 Subject: Re: [PATCH v4 3/6] mm/notifier: add migration invalidation type Message-Id: <20200728191518.GA159104@nvidia.com> List-Id: References: <20200723223004.9586-1-rcampbell@nvidia.com> <20200723223004.9586-4-rcampbell@nvidia.com> In-Reply-To: <20200723223004.9586-4-rcampbell@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ralph Campbell Cc: linux-rdma@vger.kernel.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, kvm-ppc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Glisse , John Hubbard , Christoph Hellwig , Andrew Morton , Shuah Khan , Ben Skeggs , Bharata B Rao On Thu, Jul 23, 2020 at 03:30:01PM -0700, Ralph Campbell wrote: > static inline int mm_has_notifiers(struct mm_struct *mm) > @@ -513,6 +519,7 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range, > range->start = start; > range->end = end; > range->flags = flags; > + range->migrate_pgmap_owner = NULL; > } Since this function is commonly called and nobody should read migrate_pgmap_owner unless MMU_NOTIFY_MIGRATE is set as the event, this assignment can be dropped. Jason