From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Date: Wed, 20 Oct 2021 23:28:49 +0000 Subject: Re: [PATCH] KVM: PPC: Replace zero-length array with flexible array member Message-Id: <20211020232849.GA1315641@embeddedor> List-Id: References: <20210918142138.17709-1-len.baker@gmx.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Gustavo A. R. Silva" Cc: Len Baker , Paul Mackerras , Michael Ellerman , Benjamin Herrenschmidt , Kees Cook , kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 07:05:07PM -0500, Gustavo A. R. Silva wrote: > > > On 9/18/21 09:21, Len Baker wrote: > > There is a regular need in the kernel to provide a way to declare having > > a dynamically sized set of trailing elements in a structure. Kernel code > > should always use "flexible array members" [1] for these cases. The > > older style of one-element or zero-length arrays should no longer be > > used[2]. > > > > Also, make use of the struct_size() helper in kzalloc(). > > > > [1] https://en.wikipedia.org/wiki/Flexible_array_member > > [2] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays > > > > Signed-off-by: Len Baker > > Reviewed-by: Gustavo A. R. Silva I'm taking this in my -next tree. Thanks -- Gustavo