From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Neuling Date: Sat, 12 Nov 2011 04:07:16 +0000 Subject: Re: [PATCH] powerpc kvm: fix kvmppc_start_thread() for CONFIG_SMP=N Message-Id: <2383.1321070836@neuling.org> List-Id: References: <12283.1320977000@neuling.org> <4EBD46F4.5040503@suse.de> In-Reply-To: <4EBD46F4.5040503@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: Paul Mackerras , kvm-ppc , linuxppc-dev@ozlabs.org In message <4EBD46F4.5040503@suse.de> you wrote: > On 11/11/2011 03:03 AM, Michael Neuling wrote: > > Currently kvmppc_start_thread() tries to wake other SMT threads via > > xics_wake_cpu(). Unfortunately xics_wake_cpu only exists when > > CONFIG_SMP=Y so when compiling with CONFIG_SMP=N we get: > > > > arch/powerpc/kvm/built-in.o: In function `.kvmppc_start_thread': > > book3s_hv.c:(.text+0xa1e0): undefined reference to `.xics_wake_cpu' > > > > The following should be fine since kvmppc_start_thread() shouldn't > > called to start non-zero threads when SMP=N since threads_per_core=1. > > > > Signed-off-by: Michael Neuling > > Thanks, applied to kvm-ppc-next. Please CC kvm-ppc@vger next time :). Thanks will do. Mikey