From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Date: Mon, 22 Oct 2018 09:40:10 +0000 Subject: Re: powerpc/time: Fix clockevent_decrementer initalisation for PR KVM Message-Id: <42ds233ZW4z9sDC@ozlabs.org> List-Id: In-Reply-To: <20181019042319.9457-1-mpe@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michael Ellerman , linuxppc-dev@ozlabs.org Cc: paulus@samba.org, anton@samba.org, kvm-ppc@vger.kernel.org On Fri, 2018-10-19 at 04:23:19 UTC, Michael Ellerman wrote: > In the recent commit 8b78fdb045de ("powerpc/time: Use > clockevents_register_device(), fixing an issue with large > decrementer") we changed the way we initialise the decrementer > clockevent(s). > > We no longer initialise the mult & shift values of > decrementer_clockevent itself. > > This has the effect of breaking PR KVM, because it uses those values > in kvmppc_emulate_dec(). The symptom is guest kernels spin forever > mid-way through boot. > > For now fix it by assigning back to decrementer_clockevent the mult > and shift values. > > Fixes: 8b78fdb045de ("powerpc/time: Use clockevents_register_device(), fixing an issue with large decrementer") > Signed-off-by: Michael Ellerman > Acked-by: Anton Blanchard Applied to powerpc next. https://git.kernel.org/powerpc/c/b4d16ab58c41ff0125822464bdff07 cheers