From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
Alex Williamson <alex.williamson@redhat.com>,
kvm-ppc@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [RFC,kernel] vfio/spapr_tce: Get rid of possible infinite loop
Date: Sun, 23 Dec 2018 13:28:17 +0000 [thread overview]
Message-ID: <43N38f2dkcz9sPG@ozlabs.org> (raw)
In-Reply-To: <20181002032231.7494-1-aik@ozlabs.ru>
On Tue, 2018-10-02 at 03:22:31 UTC, Alexey Kardashevskiy wrote:
> As a part of cleanup, the SPAPR TCE IOMMU subdriver releases preregistered
> memory. If there is a bug in memory release, the loop in
> tce_iommu_release() becomes infinite; this actually happened to me.
>
> This makes the loop finite and prints a warning on every failure to make
> the code more bug prone.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/517ad4ae8aa93dccdb9a88c27257ec
cheers
prev parent reply other threads:[~2018-12-23 13:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 3:22 [RFC PATCH kernel] vfio/spapr_tce: Get rid of possible infinite loop Alexey Kardashevskiy
2018-10-02 4:44 ` David Gibson
2018-10-03 18:17 ` Alex Williamson
2018-10-08 7:29 ` Serhii Popovych
2018-10-08 10:18 ` Michael Ellerman
2018-12-19 4:44 ` Alexey Kardashevskiy
2018-12-23 13:28 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43N38f2dkcz9sPG@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox