From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Leroy Date: Thu, 19 Aug 2021 09:45:37 +0000 Subject: Re: [PATCH 1/2] powerpc: kvm: rectify selection to PPC_DAWR Message-Id: <475fa73c-5eef-a60c-c70f-9f6ea7a079d8@csgroup.eu> List-Id: References: <20210819093226.13955-1-lukas.bulwahn@gmail.com> <20210819093226.13955-2-lukas.bulwahn@gmail.com> In-Reply-To: <20210819093226.13955-2-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Lukas Bulwahn , Paul Mackerras , Michael Ellerman , Benjamin Herrenschmidt , Michael Neuling , Anshuman Khandual , kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Le 19/08/2021 à 11:32, Lukas Bulwahn a écrit : > Commit a278e7ea608b ("powerpc: Fix compile issue with force DAWR") > selects the non-existing config PPC_DAWR_FORCE_ENABLE for config > KVM_BOOK3S_64_HANDLER. As this commit also introduces a config PPC_DAWR, > it probably intends to select PPC_DAWR instead. > > Rectify the selection in config KVM_BOOK3S_64_HANDLER to PPC_DAWR. > > The issue was identified with ./scripts/checkkconfigsymbols.py. > > Fixes: a278e7ea608b ("powerpc: Fix compile issue with force DAWR") > Signed-off-by: Lukas Bulwahn > --- > arch/powerpc/kvm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig > index e45644657d49..aa29ea56c80a 100644 > --- a/arch/powerpc/kvm/Kconfig > +++ b/arch/powerpc/kvm/Kconfig > @@ -38,7 +38,7 @@ config KVM_BOOK3S_32_HANDLER > config KVM_BOOK3S_64_HANDLER > bool > select KVM_BOOK3S_HANDLER > - select PPC_DAWR_FORCE_ENABLE > + select PPC_DAWR That's useless, see https://elixir.bootlin.com/linux/v5.14-rc6/source/arch/powerpc/Kconfig#L267 In arch/powerpc/Kconfig, you already have: select PPC_DAWR if PPC64 > > config KVM_BOOK3S_PR_POSSIBLE > bool >