From: Avi Kivity <avi@qumranet.com>
To: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [kvm-ppc-devel] [PATCH 2 of 2] Add PowerPC kvmctl harness and
Date: Wed, 09 Jan 2008 08:50:58 +0000 [thread overview]
Message-ID: <47848AF2.5060809@qumranet.com> (raw)
In-Reply-To: <dd6de019e916f0cc2b4f.1199837061@basalt>
Hollis Blanchard wrote:
> +
> +static int misc_init(void)
> +{
> + int err;
> +
> + err = io_table_register(&pio_table, 0xff, 1, misc_io, NULL);
> + if (err < 0)
> + return err;
> +
> + err = io_table_register(&pio_table, 0xf1, 1, misc_io, NULL);
> + if (err < 0)
> + return err;
> +
> + err = io_table_register(&pio_table, 0xf4, 1, misc_io, NULL);
> + if (err < 0)
> + return err;
> +
> + return io_table_register(&pio_table, 0xd1, 1, misc_io, NULL);
> +}
>
I thought ppc doesn't have pio (and certainly doesn't need the random
hacks above)?
While it's okay to not share code with x86 for the test harness, at
least remove the x86 specific parts.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel
prev parent reply other threads:[~2008-01-09 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 0:04 [kvm-ppc-devel] [PATCH 0 of 2] Fix kvm-userspace/user/ for PowerPC Hollis Blanchard
2008-01-09 0:04 ` [kvm-ppc-devel] [PATCH 1 of 2] Add OBJCOPY to Hollis Blanchard
2008-01-09 0:04 ` [kvm-ppc-devel] [PATCH 2 of 2] Add PowerPC kvmctl harness and fix Hollis Blanchard
2008-01-09 8:50 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47848AF2.5060809@qumranet.com \
--to=avi@qumranet.com \
--cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox