From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Date: Wed, 18 Jun 2008 13:39:10 +0000
Subject: Re: [PATCH] Initialize kvm qemu enviroment breakpoints for PowerPC
Message-Id: <48590FFE.3040707@qumranet.com>
List-Id: <kvm-ppc.vger.kernel.org>
References: <600753fabc8b38e54129.1213021421@thinkpadL>	 <1213023282.3358.2.camel@localhost.localdomain> <1213024001.6792.17.camel@thinkpadL>
In-Reply-To: <1213024001.6792.17.camel@thinkpadL>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: jyoung5@us.ibm.com
Cc: Hollis Blanchard <hollisb@us.ibm.com>, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org

Jerone Young wrote:
> On Mon, 2008-06-09 at 09:54 -0500, Hollis Blanchard wrote:
>   
>> On Mon, 2008-06-09 at 09:23 -0500, Jerone Young wrote:
>>     
>>> diff --git a/qemu/gdbstub.c b/qemu/gdbstub.c
>>> --- a/qemu/gdbstub.c
>>> +++ b/qemu/gdbstub.c
>>> @@ -983,6 +983,7 @@ static int gdb_handle_packet(GDBState *s
>>>              kvm_load_registers(env);
>>>  #elif defined (TARGET_PPC)
>>>              env->nip = addr;
>>> +            kvm_load_registers(env);
>>>  #elif defined (TARGET_SPARC)
>>>              env->pc = addr;
>>>              env->npc = addr + 4;
>>> @@ -1021,6 +1022,7 @@ static int gdb_handle_packet(GDBState *s
>>>              kvm_load_registers(env);
>>>  #elif defined (TARGET_PPC)
>>>              env->nip = addr;
>>> +            kvm_load_registers(env);
>>>  #elif defined (TARGET_SPARC)
>>>              env->pc = addr;
>>>              env->npc = addr + 4;
>>>       
>> These should be protected by a kvm_enabled() test, just like you see for
>> x86 four lines earlier.A
>>     
>
> Actually the line above is x86 and it is not using kvm_enabled() before
> calling kvm_load_registers().
>
>   

Yes, kvm_load_registers() has a built-in kvm_enabled() test.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.