From: Avi Kivity <avi@redhat.com>
To: kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] kvm: external module: fix unifdef problem
Date: Mon, 27 Oct 2008 16:29:24 +0000 [thread overview]
Message-ID: <4905EC64.7090603@redhat.com> (raw)
In-Reply-To: <1224871854.9634.50.camel@localhost.localdomain>
Christian Ehrhardt wrote:
> Hollis and I discussed how to continue on that.
> Atm the upstream code is broken for powerpc and your response is too
> vague for me to extend our patch in some way.
> So which way should we go? Will you apply (or should I resubmit ?)
> Hollis patch for now to fix upstream for powerpc. And we/you extend it
> later or what else would you prefer?
My thinking is that we convert CONFIG_* to __i386__, __x86_64__,
__powerpc__, and the like, using the hack-modules pass in 'make sync'.
The advantages of that are:
- 'make sync' headers are architecture independent. Currently once you
run 'make sync', the headers become tied to the arch, even the ones in
include/linux
- The headers are standalone -- no need for -DCONFIG_* in anything that
includes it
- We already mangle things, so it's not a big change
I think Xiantao was going to try it, but if not, then please do it
yourself. I could too, of course, but I prefer someone that can test on
non-x86 do it.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-10-27 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 18:10 [PATCH] kvm: external module: fix unifdef problem Hollis Blanchard
2008-10-26 12:38 ` Avi Kivity
2008-10-27 0:58 ` Sheng Yang
2008-10-27 16:07 ` Christian Ehrhardt
2008-10-27 16:29 ` Avi Kivity [this message]
2008-10-28 1:02 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4905EC64.7090603@redhat.com \
--to=avi@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox