From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Cc: KVM list <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>,
Hollis Blanchard
<hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
"Zhang,
Xiantao" <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Subject: Re: qemu-kvm.git now live
Date: Wed, 29 Apr 2009 14:40:03 +0000 [thread overview]
Message-ID: <49F866C3.8090904@redhat.com> (raw)
In-Reply-To: <49F83A8A.8040909-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Jan Kiszka wrote:
>> If migration disables dirty memory logging, it must keep the vga logging
>> enabled, and vice versa.
>>
>
> So we need some notifier callbacks on slot changes so that all users can
> re-enable dirty logging after the update as required.
Simpler to do reference counting. When a user enables logging for a
memory range, the refcount for all slots containing that range gets
bumped. When a user enables logging for all of memory, a global
refcount is bumped. For a given slot, dirty logging is enabled if
either the slot logging refcount or the global logging refcount is nonzero.
That's sort of what's implemented in qemu-kvm.git. In qemu.git vga
logging does not get disabled, which is really broken. It prevents
optimizations like disabling logging when the screen is not displayed to
a human.
> Where/how does the
> migration code disable dirty logging?
>
Should be phase 3 of ram_save_live().
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2009-04-29 14:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 15:40 qemu-kvm.git now live Avi Kivity
2009-04-23 17:33 ` walt
2009-04-24 2:49 ` Liu Yu-B13201
[not found] ` <0A1FE637C2C7E148B9573BB60CC630E5210156-bKEhWGtIRUJ4Lp7cDGe+DVjVikpgYyvb5NbjCUgZEJk@public.gmane.org>
2009-04-26 9:22 ` Avi Kivity
2009-04-26 7:38 ` [PATCH] qemu-kvm: configure script fixups after qemu-kvm reorg Michael S. Tsirkin
2009-04-26 7:48 ` Gleb Natapov
2009-04-26 8:15 ` Michael S. Tsirkin
2009-04-26 8:51 ` Michael S. Tsirkin
[not found] ` <49F08BD0.6000706-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-04-28 21:53 ` qemu-kvm.git now live Hollis Blanchard
[not found] ` <1240955602.24625.57.camel-EGjIuKC2qUdB0N6nvOmcJFaTQe2KTcn/@public.gmane.org>
2009-04-28 22:20 ` Anthony Liguori
2009-04-28 22:24 ` Glauber Costa
[not found] ` <5d6222a80904281524v5eb5b163pd21e7d6643cbdbc6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-04-28 22:28 ` Anthony Liguori
2009-04-28 22:34 ` Hollis Blanchard
[not found] ` <49F78134.30904-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2009-04-28 22:33 ` Hollis Blanchard
[not found] ` <1240957999.24625.60.camel-EGjIuKC2qUdB0N6nvOmcJFaTQe2KTcn/@public.gmane.org>
2009-04-29 8:31 ` Avi Kivity
[not found] ` <49F81054.4010102-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-01 21:51 ` Hollis Blanchard
[not found] ` <1241214678.32624.176.camel-EGjIuKC2qUdB0N6nvOmcJFaTQe2KTcn/@public.gmane.org>
2009-05-02 7:52 ` Avi Kivity
[not found] ` <49FBFBC4.10905-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-04 21:35 ` Hollis Blanchard
2009-04-29 8:29 ` Avi Kivity
[not found] ` <49F80FE2.5030600-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-05-01 21:23 ` Hollis Blanchard
[not found] ` <1241213025.32624.167.camel-EGjIuKC2qUdB0N6nvOmcJFaTQe2KTcn/@public.gmane.org>
2009-05-01 22:55 ` Anthony Liguori
[not found] ` <49FB7DF4.60201-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2009-05-02 7:42 ` Avi Kivity
2009-05-02 7:54 ` Avi Kivity
2009-05-02 7:58 ` Avi Kivity
2009-05-02 14:50 ` Muli Ben-Yehuda
2009-04-29 8:49 ` Jan Kiszka
[not found] ` <49F81496.8030407-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2009-04-29 10:42 ` Avi Kivity
2009-04-29 10:55 ` Jan Kiszka
[not found] ` <49F83227.9000502-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2009-04-29 11:12 ` Avi Kivity
2009-04-29 11:31 ` Jan Kiszka
[not found] ` <49F83A8A.8040909-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2009-04-29 14:40 ` Avi Kivity [this message]
2009-04-29 15:42 ` Jan Kiszka
2009-04-30 9:12 ` Avi Kivity
[not found] ` <49F96B6F.6050005-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-04-30 9:29 ` Jan Kiszka
[not found] ` <49F96F5E.6060404-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2009-04-30 10:54 ` Avi Kivity
[not found] ` <49F98365.3080907-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-04-30 15:32 ` Jan Kiszka
[not found] ` <49F9C491.80205-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2009-04-30 15:43 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F866C3.8090904@redhat.com \
--to=avi@redhat.com \
--cc=anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org \
--cc=cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org \
--cc=kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox