From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Date: Mon, 09 Nov 2009 23:22:25 +0000 Subject: Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific Message-Id: <4AF8A431.3040607@us.ibm.com> List-Id: References: <204026d59328febd9789.1257800737@localhost.localdomain> <4AF893BC.2040507@web.de> In-Reply-To: <4AF893BC.2040507@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jan Kiszka Cc: hollisb@linux.vnet.ibm.com, kvm-ppc , qemu-devel Jan Kiszka wrote: > Hollis Blanchard wrote: > >> Unbreaks PowerPC and S390 KVM builds. >> > > What breaks precisely? > > Note that KVM_GET/SET_MP_STATE are generic IOCTLs and supposed to be > shared with ia64 - one day. We could still move things back then, but > maybe we can handle the build issues already in place, specifically as > qemu-kvm is carrying this in generic code since ages. > mp_state is pretty specific to the in-kernel apic. ia64 may share because it shares an interrupt controller but that does not make it generic. That just makes two architectures have a common field. I don't think there's anything wrong with kvm exposing this as a common ioctl but from a qemu perspective, it makes no sense as a common cpu field. It only makes sense when using kvm and when using an in-kernel apic. That's very architecture specific from an qemu perspective. -- Regards, Anthony Liguori