Kernel KVM-PPC virtualization development
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] KVM: PPC: Pass through program interrupts
Date: Sun, 10 Jan 2010 14:26:25 +0000	[thread overview]
Message-ID: <4B49E391.60108@redhat.com> (raw)
In-Reply-To: <4B49C684.8080407-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On 01/10/2010 02:22 PM, Avi Kivity wrote:
> On 01/10/2010 04:27 AM, Alexander Graf wrote:
>> When we get a program interrupt in guest kernel mode, we try to 
>> emulate the
>> instruction.
>>
>> If that doesn't fail, we report to the user and try again - at the 
>> exact same
>> instruction pointer. So if the guest kernel really does trigger an 
>> invalid
>> instruction, we loop forever.
>>
>> So let's better go and forward program exceptions to the guest when 
>> we don't
>> know the instruction we're supposed to emulate.
>>
>
> Applied both, and queued for .33.  I was able to guess this from the 
> description, but please mention it explicitly in the future.
>

I get this building ppc32:

scripts/kconfig/conf -s arch/powerpc/Kconfig
   CHK     include/linux/version.h
   CHK     include/generated/utsrelease.h
   CALL    scripts/checksyscalls.sh
<stdin>:1523:2: warning: #warning syscall recvmmsg not implemented
   CC      arch/powerpc/kvm/emulate.o
arch/powerpc/kvm/emulate.c: In function 'kvmppc_emulate_instruction':
arch/powerpc/kvm/emulate.c:467: error: too many arguments to function 
'kvmppc_core_queue_program'
make[1]: *** [arch/powerpc/kvm/emulate.o] Error 1



-- 
error compiling committee.c: too many arguments to function


  parent reply	other threads:[~2010-01-10 14:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-10  2:27 [PATCH 1/2] KVM: PPC: Pass through program interrupts Alexander Graf
2010-01-10 12:22 ` Avi Kivity
     [not found]   ` <4B49C684.8080407-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-01-10 12:32     ` Alexander Graf
     [not found]       ` <3F51B03C-D36B-49F9-9AF3-EF5227DFAE3F-l3A5Bk7waGM@public.gmane.org>
2010-01-10 12:37         ` Avi Kivity
     [not found]           ` <4B49CA20.6000303-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-01-10 12:46             ` Alexander Graf
2010-01-10 14:26     ` Avi Kivity [this message]
     [not found]       ` <4B49E391.60108-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-01-10 15:06         ` Alexander Graf
     [not found]           ` <A5862364-1443-4A32-85B8-13B11B2E55DA-l3A5Bk7waGM@public.gmane.org>
2010-01-10 15:09             ` Avi Kivity
     [not found]               ` <4B49EDBA.9040306-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-01-10 15:28                 ` Alexander Graf
     [not found]                   ` <A21E3A8F-81D1-468A-BE37-9CB5718E1FB8-l3A5Bk7waGM@public.gmane.org>
2010-01-10 15:37                     ` Avi Kivity
2010-01-10 15:54                       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B49E391.60108@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf-l3A5Bk7waGM@public.gmane.org \
    --cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox