From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Sun, 17 Jan 2010 12:33:21 +0000 Subject: Re: [PATCH 0/6] KVM: PPC: FPU/Altivec/VSX bringup Message-Id: <4B530391.6000701@redhat.com> List-Id: References: <1263563354-11075-1-git-send-email-agraf@suse.de> In-Reply-To: <1263563354-11075-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: kvm-ppc , KVM General On 01/15/2010 03:49 PM, Alexander Graf wrote: > Right now the code to use external providers (FPU/Altivec/FSX) is rather hacky. > > We just set the respective feature bit in the guest MSR when the guest requests > it and declare it as good. Now, Linux wants to mess around there too, so > whenever a process switch occurs, it saves the external provider state and > reloads the current thread ones'. > > Unfortunately, we didn't tell Linux about our guest state. So Linux doesn't even > get the chance to swap any of our registers around which means it ends up > restoring registers from random processes - and we lose all state. > > This patchset makes at least FPU and Altivec work. I don't have a VSX machine to > test that extension on. While at it, it also fixes some issues I've stumbled > across during debug. > > The basic ideas on how this should work come from Benjamin Herrenschmidt. > Thanks a lot for giving input on this one (and all the other times)! > Applied all, thanks. -- error compiling committee.c: too many arguments to function