From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
Cc: Jim Paris <jim-XrPbb/hENzg@public.gmane.org>,
kvm-ppc <kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
kvm-devel list <kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 5/8] KVM: PPC: Be more informative on BUG
Date: Mon, 19 Apr 2010 08:41:55 +0000 [thread overview]
Message-ID: <4BCC1753.7080105@redhat.com> (raw)
In-Reply-To: <6F7AA5B9-AE83-494B-99C2-22BCF927D4EC-l3A5Bk7waGM@public.gmane.org>
On 04/19/2010 04:26 AM, Alexander Graf wrote:
>
>> Very true. In fact, I certainly remember me putting a return and a WARN_ON(true) because WARN() gave me a warning here. I wonder where that code went ... hrm ...
>> Either way, thanks for looking over this patch!
>>
> Ugh - I messed up my patch rebasing. The hunk to put the return there is included in 6/8.
>
> Oh well, I don't think that's enough of a bummer for a resubmit. Avi, please apply this set nevertheless.
>
>
I don't see it in 6/8.
Please fix it up regardless, I run bisectability tests on submissions
and don't want to puzzle out any warnings.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-04-19 8:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 23:36 [PATCH 0/8] Post-PPC32 series Alexander Graf
2010-04-18 23:36 ` [PATCH 1/8] KVM: PPC: Convert u64 -> ulong Alexander Graf
2010-04-18 23:36 ` [PATCH 2/8] KVM: PPC: Make Performance Counters work Alexander Graf
2010-04-18 23:36 ` [PATCH 3/8] KVM: PPC: Improve split mode Alexander Graf
2010-04-18 23:36 ` [PATCH 4/8] KVM: PPC: Make Alignment interrupts work again Alexander Graf
2010-04-18 23:36 ` [PATCH 5/8] KVM: PPC: Be more informative on BUG Alexander Graf
2010-04-19 1:01 ` Jim Paris
[not found] ` <20100419010125.GA10309-SRSuHwkuBJlaX0KmTac7FA@public.gmane.org>
2010-04-19 1:07 ` Alexander Graf
[not found] ` <9B8FF539-36C7-4976-87B0-DF5A75492C92-l3A5Bk7waGM@public.gmane.org>
2010-04-19 1:26 ` Alexander Graf
[not found] ` <6F7AA5B9-AE83-494B-99C2-22BCF927D4EC-l3A5Bk7waGM@public.gmane.org>
2010-04-19 8:41 ` Avi Kivity [this message]
2010-04-18 23:36 ` [PATCH 6/8] KVM: PPC: Set VSID_PR also for Book3S_64 Alexander Graf
[not found] ` <1271633816-7863-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org>
2010-04-18 23:36 ` [PATCH 7/8] KVM: PPC: Fix Book3S_64 Host MMU debug output Alexander Graf
2010-04-18 23:36 ` [PATCH 8/8] KVM: PPC: Find HTAB ourselves Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCC1753.7080105@redhat.com \
--to=avi@redhat.com \
--cc=agraf-l3A5Bk7waGM@public.gmane.org \
--cc=jim-XrPbb/hENzg@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox