Re: [PATCH 09/14] KVM: PPC: Add generic single register ioctls

Marcelo Tosatti
2011-12-19T17:29:25Z

On Mon, Dec 19, 2011 at 01:58:32PM +0100, Alexander Graf wrote:
> I still don't fully understand. You pass in a list of register modifications. The same would happen from guest code. You have a code stream of register modifications. They should both end up calling the same functions in the kernel at the end of the day with the same order. If you call XYZ_REGISTER_SET and then GET_ONE_REG, you get the same the guest would get.
>
> If it's difficult to implement for specific registers then just don't implement those with the ONE_REG interface. You're not forced to implement all registers with either interface - it's mostly a nicely extensible interface for architectures that evolve quite a bit with people implementing things only partially and then later realizing what's missing :). In other words, it should work great for us ppc folks and I'm fairly sure the ARM guys will appreciate it too. X86 is rather stable and well-exploited, so I can see how it doesn't make sense to use it there.
>

I was picturing a convertion of x86 to use that interface. My bad.