From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Thu, 22 Dec 2011 10:03:52 +0000 Subject: Re: [PATCH 08/28] kvm tools: Fix KVM_RUN exit code check Message-Id: <4EF30088.6090606@redhat.com> List-Id: References: <4EDD8E82.1010909@ozlabs.org> <1323159768.3882.9.camel@lappy> <4EE028E5.7080207@ozlabs.org> <1323322304.3904.6.camel@lappy> In-Reply-To: <1323322304.3904.6.camel@lappy> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sasha Levin Cc: Matt Evans , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org On 12/08/2011 07:31 AM, Sasha Levin wrote: > > > > It sounds like Alex is considering KVM PPC's return value in this case (and > > updating api.txt if appropriate) -- what say you on this patch? It actually > > brings kvmtool's KVM_RUN return val check in line with QEMU's (also "< 0") and > > nothing PPC will run without it, currently. (I'm about to repost a new series, > > will include it for these reasons, until I hear more complaint ;) ) > > '<0' is fine as it's what api.txt says :) What? ioctls return -1 on error, not <0. The syscalls do return <0, but libc converts that to -1/errno. -- error compiling committee.c: too many arguments to function